Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch/issue 75 #76

Merged
merged 5 commits into from
Oct 30, 2023
Merged

Patch/issue 75 #76

merged 5 commits into from
Oct 30, 2023

Conversation

anngvu
Copy link
Contributor

@anngvu anngvu commented Oct 25, 2023

Fixes #75; there were actually two things going on that were good to catch:

  1. CONFIG in test file was not pointing to the DCA staging config, so even when config was updated there, running test-generate would have ignored re-rendering template.
  2. This one's a little tricky, but good to be aware of: So can see a block for "Dead" component removed here https://github.com/gf-dcc/data-model/compare/patch/issue-75?expand=1#diff-74bb61d0c141447a8ff6ff5097fad1de065f061a7e4979bfc887a8e617e9b6ffL274. The way this works is that "Dead" is a potential selection for "Vital Status" field. So this will pull in all the things under the "Dead" component as extra columns. I personally don't like how this works because it's kind of weird/not super clear behavior. It shouldn't have been a component and something we should have cleaned up.

@github-actions
Copy link

Test Suite Report

Template Generation

template result link
CohortCoreTemplate 😄 template link
ImagingLevel2 😄 template link
ImagingLevel2Channels 😄 template link
ScATAC-seqLevel1 😄 template link
ScRNA-seqLevel1 😄 template link
ScRNA-seqLevel2 😄 template link
ScRNA-seqLevel3 😄 template link
ScRNA-seqLevel4 😄 template link

Manifest Validation

TODO

@anngvu anngvu requested a review from cconrad8 October 25, 2023 23:04
@cconrad8 cconrad8 merged commit c901f35 into main Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CohortCoreTemplate contains extra terms
3 participants